Hi guys, in the <current implementation> of the `p...
# squads
k
Hi guys, in the current implementation of the
plot_hierarchical_predictions_gap
function, we cannot get the matplotlib Figure (fig) object. Is that correct? I don't I want to get access to the fig object so that I can save the plot as a svg file:
Copy code
fig.savefig("images/output_plot.svg", format="svg", bbox_inches="tight")
Should we return the fig object at the end of the function?
Copy code
plt.show()
return fig, ax
m
If you only want to save the figure, just returning
fig
is enough. But I don't see a problem with returning the
ax
either...
k
yeah returning a fig is enough. Should I submit a PR for this?
m
Yes
👍 1
k
@Marco Can you review this PR?
m
You need to modify the notebook and use nbdev to make that kind of changes. You can look at CONTRIBUTING.md for details
k
Ah dang. Okay I will
Is it normal for conda to take forever to solve the environment using this command? We only use a few packages
Copy code
$ conda env update -f environment.yml
Collecting package metadata (repodata.json): done
Solving environment:
m
Hmm.. not sure
k
Okay I edited the code using nbdev
I wonder if running
nbdev_clean
and
nbdev_export
in the CONTRIBUTING.md is necessary if we have nbdev pre-commit hooks